fix(a11y-status): escape HTML in statuses #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why:
Potential XSS attack in generation of a11y status messages. Need to escape input before rendering those.
How:
Escape input by building the a11y status div using DOM API and fill in status message using
textContent
, which automatically escapes text (wanted to useinnerText
but it's not supported in Enzyme tests).When using the DOM API, previous children will need to removed manually. I opted for using a loop and
Node.removeChild
overNode.innerHTML = ''
because the former is more performant.Checklist: