Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mouseup): do not reset when active element is in downshift #383

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

kentcdodds
Copy link
Member

What: do not reset when active element is in downshift

Why: Closes #356

How:

  • Add util for checking whether a node is or contains something
  • Use that util for both the event.target and the document.activeElement
  • Use that instead of the input

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table N/A

@kentcdodds
Copy link
Member Author

This is the last PR before I create the next branch. All future work will start there until it's merged. Hopefully we'll get that merged before the week is out.

@kentcdodds kentcdodds merged commit 8559b79 into master Mar 20, 2018
@kentcdodds kentcdodds deleted the pr/mouse-up-improvements branch March 20, 2018 21:38
@codecov-io
Copy link

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #383   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         338    337    -1     
  Branches       90     90           
=====================================
- Hits          338    337    -1
Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) ⬆️
src/downshift.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809303a...4f2f39e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants