-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing 'suppressRefError' option typings #556
add missing 'suppressRefError' option typings #556
Conversation
66c2c4a
to
a2233a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great except those in the README. Could you remove that? Thanks!
README.md
Outdated
@@ -495,6 +496,12 @@ node you render in downshift). Internally we use | |||
so if you use that package then you wont be adding any additional bytes to your | |||
bundle :) | |||
|
|||
### suppressRefError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excluded from the docs intentionally. It's a pretty far edge case so I don't think it's worth including in the docs.
a2233a7
to
e8eebe6
Compare
fixes done |
@kentcdodds LGTM, I'll rebase my PR after merging #534 |
627c4a8
to
2c74580
Compare
done |
Yes... Do you have dependencies installed? |
haha, it was so obvious, sorry. I had an experience to run prettier/linters (without --fix) also on CI, I think it is more reliable solution than pre-commit |
I'm not sure why the precommit script is not running for you. It should be automatically generating the contributors table in the README as well as running prettier on all changed files... 🤔 |
It's because I didn't install npm deps, as you mentioned earlier. It was obvious, but I didn't catch it :) Now it is ok. |
2c74580
to
b1c1334
Compare
How do you suggest we update the pull request someone else opened? I know it's possible, but it'd be a bit more work than I would like to do myself. |
🎉 This PR is included in version 2.1.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
On CI we don't modify code, just fail check. After that author and reviewer realise that something went wrong with precommit hook and fix it Summarize:
We ran into same problems with linters, because colleagues forget to install deps or pass --no-verify to git or other reasons. Nevertheless, thanks for your quick reaction for this PR! |
Oh, we definitely do that via the |
What:
Missing TypeScript (TS) typings added - second argument to
getRootProps
andgetMenuProps
functionsChecklist: