Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the latest schema and make some tweaks to the date filters #7

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Update to the latest schema and make some tweaks to the date filters #7

merged 5 commits into from
Jul 27, 2023

Conversation

eduardoborba
Copy link
Contributor

@eduardoborba eduardoborba commented Jul 26, 2023 •
edited
Loading

  • Generate the code using the latest schema 2.24.1
  • Make tweaks to the date filters to translate better into code
    • Change all the date filters from string with a date format to a number, as the expected values are one of these:
      • 1 - Today
      • 2 - Past 7 days
      • 3 - Past 30 days
      • 4 - Past 90 days
      • 5 - Current month
      • 6 - Current year
      • 7 - Past year
    • Remove the empty string from the enumerator as it's not a valid value

@eduardoborba eduardoborba self-assigned this Jul 26, 2023
keatly91
keatly91 reviewed Jul 27, 2023
View reviewed changes
Copy link

@keatly91 keatly91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to delete the Defect-Dojo-API-v2.8.0.json version as well.

Defect-Dojo-API-v2.24.1.json
Copy link

@keatly91 keatly91 Jul 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put an example or reference (a3b7195) to the tweaks made to the date filters in the PR description?

@eduardoborba eduardoborba merged commit ada1cf4 into master Jul 27, 2023
@eduardoborba eduardoborba deleted the eb/update-to-the-latest-schema branch July 27, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keatly91 keatly91 keatly91 approved these changes

Assignees

@eduardoborba eduardoborba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoborba @keatly91