Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrollback length is larger than visible rows. There're 2 issues that I've found.
Example config
1. Extra rows returned
The
.skip
method will skip the first 4 (10 - 6 = 4) rows, thus it'll return 6 rows in total.Even though we only want 3.
This is fixed by setting the upper bound via
.take(rows_len)
.2. Subtraction overflow
The
.chain
method will take additional rows viarows_len - offset
i.e. 3 - 6 = overflow! We just need 0 rows.This is fixed by using saturation.
Fix #4 #5