Fixed '(plugin.variable || []).forEach is not a function' #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes '(plugin.variable || []).forEach is not a function' when using this plugin together with some others (e.g. calendar). The problem is triggered when plugin.variable is not an array but an object as follows:
{ _attributes:
{ name: 'CALENDAR_USAGE_DESCRIPTION',
value: 'This app can sync your calendar.' } }
DeepCode Report (#13faca)DeepCode analyzed this pull request. |
|
#219 now resolves this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
This commit fixes '(plugin.variable || []).forEach is not a function' when using this plugin together with some others (e.g. calendar). The problem is triggered when plugin.variable is not an array but an object as follows:
{ _attributes:
{ name: 'CALENDAR_USAGE_DESCRIPTION',
value: 'This app can sync your calendar.' } }
With this fix, it will work either way.
Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
What testing has been done on existing functionality?
Other information