Fix .forEach is not a function #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#e44463)DeepCode analyzed this pull request. |
|
Thanks, checked the logic and this makes sense. |
9 tasks
dpa99c
added
the
ready for release
dpa99c
removed
the
ready for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
As described in #217 the after_prepare script hangs with error
.forEach is not a function. This happens either if there is only one plugin configuration in the config.xml or if a plugin configuration only has one variable. This is due toconfig.widget.pluginorplugin.variablenot being arrays in this cases. This PR makes sure that both always are arrays.Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
Tested with different config.xml scenarios.
What testing has been done on existing functionality?
Tested with different config.xml scenarios.
Other information
The open PR #213 (which I discovered just now before submitting mine) does not fix both cases.