Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'name' attribute (if set) in webform mapping #1411

Conversation

bgilhome-now
Copy link
Contributor

PR for feature request #1410

Issue:

What I did

  • Use 'name' attribute if set in webform element config as the field key/name, else use machine_name as usual.

How to test

  • Build a webform, and for an element, add a custom 'name' attribute in the element's config
  • View the form in the frontend and confirm the HTML 'name' attribute uses the custom value

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday changed the base branch from develop to release/2.23.0 December 12, 2024 05:36
@waitingallday waitingallday added this to the 2.23.0 milestone Dec 12, 2024
@waitingallday waitingallday merged commit e65d674 into dpc-sdp:release/2.23.0 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants