Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add example id to search banner story #1418

Open
wants to merge 1 commit into
base: release/2.24.0
Choose a base branch
from
Open

fix: add example id to search banner story #1418

wants to merge 1 commit into from
+4 −1

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Dec 31, 2024

What I did

  • Add example id to search banner story to fix axe error

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.24.0 milestone Dec 31, 2024
@lambry lambry self-assigned this Dec 31, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 31, 2024

ripple-framework    Run #2485

Run Properties:  status check passed Passed #2485  •  git commit 5f0380d520: fix(@dpc-sdp/ripple-ui-core): add id to search banner story
Project ripple-framework
Branch Review bugfix/add-example-id
Run status status check passed Passed #2485
Run duration 10m 31s
Commit git commit 5f0380d520: fix(@dpc-sdp/ripple-ui-core): add id to search banner story
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 218
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.24.0
Development

Successfully merging this pull request may close these issues.
1 participant
@lambry