start unit testing

[caub]

Just a beginning for what I think could be useful as simple unit tests, it may be hacky

Don't hesitate to tell/close if you don't like this approach :)

and quick question: shouldn't this be case insensitive?

ps: I'm making this kind of thing also because I'm thinking about doing a minimal and lightweight dom implementation for svgo and use nwsapi on it

[dperini]

@caub sure ... anything related to testing is really important to follow improvements without having to manually recheck everything and to avoid regressions. Test automation is good.

Though I don't feel I have strong knowledge on current tools and practices.

As you can see there are a couple of test suites already available in the test folder and I am going to start adding WPT tests, only those related to selectors not the full suite.

[caub]

@dperini I'm going to add WPT tests (similarly to jsdom)

When you've time, I'd like to figure out why https://github.com/caub/nwsapi/blob/test/test/unit.js#L173-L193 is not giving me what I'd expect

[dperini]

@caub I looked into this and the only thing I can think of is that maybe the DOM you are building is missing some of the properties that "nwsapi" need to figure out things and/or auto configure.

They could be properties of document, like ".contentType" or properties of the elements themselves like ".localName", ".nodeName", ".namespaceURI" to be able to decide on the type of check to perform in the building of the function resolver.

No other ideas till now should I have other findings I will report them here.

[caub]

Hmm I don't really know how to run WPT tests for nwsapi, would we have to make a script to insert <script src="path/to/nwsapi.js"></script> in each file in dom/nodes)?

For now it's quite good enough to test on jsdom no?

Btw, still trying to make https://github.com/caub/nwsapi/blob/test/test/unit.js work, like I told you it'd allow to integrate nwsapi in any parser, like a custom svg parser (particularly for svgo), besides also allowing easy tests.

[dperini]

@caub
The current method I use to test "nwsapi" against WPT in browsers is by manually executing "test/w3c-test.sh" from a terminal.

That requires a recent version of PHP7 installed since that shell snippet executes the HTTP server embedded in the PHP7. At that point you can access the list of WPT tests by connecting to "localhost:8000" with the browser of choice.

The other tests can be run simply by loading the ".html" file in each folder.

From 'jsdom' you have to "npm run test" from inside the 'jsdom' root folder.