fix: Set certificates before reconnecting to LDAP #1846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi Flask-AppBuilder team,
we set up Superset - using Flask-AppBuilder - to use an LDAP connection as described in your documentation.
The first time a user tries to log into the Superset instance the login will always fail with the following error shown in the logs:
The second login would than pass (if the credentials are correct).
This patches solves the issue, so that the first login attempt passes.
The docs of python-ldap say
We have to set all the certificates before we set OPT_X_TLS_NEWCTX to 0 so that the correct certificates are set.
ADDITIONAL INFORMATION