chore: dont add 'tests' package to wheel #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in commit 7f194cf, the tests package got moved from within the 'flask_appbuilder' namespace into the root namespace, but the package was not explicitely excluded from the wheel in setuptools. As a result, all the FAB tests would get installed into the 'tests' package namespace during an installation of the FAB 4.3.4 wheel. Furthermore, if other wheels would also ship modules inside the 'tests' namespace, these modules would get overidden. Package managers like `pip` probably wouldn't even notice. But other package managers (e.g. `dpkg` or `rpm`) will detect such conflicts and will complain about it loudly and refuse to install packages with conflicting files.
|
You're welcome. I think I'm probably the only person installing python packages as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in commit 7f194cf, the tests package got moved from within the
'flask_appbuilder' namespace into the root namespace, but the package
was not explicitely excluded from the wheel in setuptools.
As a result, all the FAB tests would get installed into the 'tests'
package namespace during an installation of the FAB 4.3.4 wheel.
Furthermore, if other wheels would also ship modules inside the 'tests'
namespace, these modules would get overidden. Package managers like
pipprobably wouldn't even notice.But other package managers (e.g.
dpkgorrpm) will detect suchconflicts and will complain about it loudly and refuse to install
packages with conflicting files.