Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wtforms compat 3.1.0 #2138

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix: wtforms compat 3.1.0 #2138

merged 3 commits into from
Oct 16, 2023

Conversation

dpgaspar
Copy link
Owner

Description

fixes: #2137

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@dpgaspar dpgaspar changed the title Fix/wtforms compat 3.1.0 fix: wtforms compat 3.1.0 Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #2138 (979472f) into master (5f30fd7) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2138      +/-   ##
==========================================
- Coverage   78.66%   78.65%   -0.02%     
==========================================
  Files          72       72              
  Lines        8686     8695       +9     
==========================================
+ Hits         6833     6839       +6     
- Misses       1853     1856       +3     
Flag Coverage Δ
python 78.65% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flask_appbuilder/fields.py 68.91% <75.00%> (-0.15%) ⬇️

Copy link
Contributor

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. A bit blurry if it's a breaking API or not (WTForms likely did not realising this change might break some users). This seems like a reasonable way to solve it though.

@dpgaspar dpgaspar merged commit 56fe5d8 into master Oct 16, 2023
10 of 12 checks passed
@dpgaspar dpgaspar deleted the fix/wtforms-compat-3.1.0 branch October 16, 2023 10:23
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 20, 2023
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from
4.3.6.

It incorporates those changes:

* dpgaspar/Flask-AppBuilder#2112
* dpgaspar/Flask-AppBuilder#2121

It also removes the limitation of the WTForms after compatibility has
been implemented:

* dpgaspar/Flask-AppBuilder#2138
potiuk added a commit to apache/airflow that referenced this pull request Oct 21, 2023
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from
4.3.6.

It incorporates those changes:

* dpgaspar/Flask-AppBuilder#2112
* dpgaspar/Flask-AppBuilder#2121

It also removes the limitation of the WTForms after compatibility has
been implemented:

* dpgaspar/Flask-AppBuilder#2138
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 18, 2024
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from
4.3.6.

It incorporates those changes:

* dpgaspar/Flask-AppBuilder#2112
* dpgaspar/Flask-AppBuilder#2121

It also removes the limitation of the WTForms after compatibility has
been implemented:

* dpgaspar/Flask-AppBuilder#2138

GitOrigin-RevId: 4198146f49b72d051d82fbd821c7105cf2f4a8bd
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 20, 2024
This PR brings all the necessary changes to upgrade to FAB 4.3.9 from
4.3.6.

It incorporates those changes:

* dpgaspar/Flask-AppBuilder#2112
* dpgaspar/Flask-AppBuilder#2121

It also removes the limitation of the WTForms after compatibility has
been implemented:

* dpgaspar/Flask-AppBuilder#2138

GitOrigin-RevId: 4198146f49b72d051d82fbd821c7105cf2f4a8bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Just released WTForms 3.1.0 break FAB widgets (including just released 4.3.8)
2 participants