You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I didn't have time yet to do tests... Given that the existing KafkaAdminClient code currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.
Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing #1193, as that will both simplify the code drastically and require a few fixture changes.
And then after that tackle the tests/missing coverage.
But creating this and assigning it to myself so that I don't forget
The text was updated successfully, but these errors were encountered:
I need to add tests for the KafkaAdmin changes I made:
validate_only
/include_synonyms
#1645I didn't have time yet to do tests... Given that the existing
KafkaAdminClient
code currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing #1193, as that will both simplify the code drastically and require a few fixture changes.
And then after that tackle the tests/missing coverage.
But creating this and assigning it to myself so that I don't forget
The text was updated successfully, but these errors were encountered: