Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the removal of Simple* and that the KafkaClient is the new one, not the old one #1926

Closed
jeffwidman opened this issue Oct 11, 2019 · 1 comment
Closed

Document the removal of Simple* and that the KafkaClient is the new one, not the old one #1926

jeffwidman opened this issue Oct 11, 2019 · 1 comment
Milestone
2.0

Comments

@jeffwidman
Copy link
Collaborator

jeffwidman commented Oct 11, 2019 •
edited
Loading

This is a followup for #1196.

Need to document that the SimpleClient/SimpleConsumer/SimpleProducer are all gone and that if you need them, use an older version.

Also need to document that KafkaClient now refers to the new async client, not the old deprecated one.

Honestly, the changelog is probably the only place that really needs it... maybe at the bottom of the readme and the top of the KafkaClient docs could mention the change as well for folks confused on why KafkaClient behavior suddenly changed.
@jeffwidman jeffwidman added this to the 2.0 milestone Oct 11, 2019
@jeffwidman jeffwidman mentioned this issue Oct 11, 2019
Merged
3 tasks
@jeffwidman
Copy link
Collaborator Author

This was covered in the changelog: ed8c9cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@jeffwidman