Dont refresh metadata on failed group coordinator request unless needed #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkp
force-pushed
the
check_invalid_metadata
branch
from
60b4c9d to
537bfd1
Compare
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing group coordinator discovery code triggers a metadata refresh on any error other than a small whitelist (GroupCoordinatorNotAvailableError). This PR drops the whitelist in favor of a simple check for the invalid_metadata attribute on retriable kafka errors.
This is expected to reduce unneeded metadata refreshes when, for example, the socket is simply still connecting (NodeNotReadyError).