Add private map of api key -> min/max versions to BrokerConnection #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,3 +6,40 @@ | |||
| CODEC_NONE, CODEC_GZIP, CODEC_SNAPPY, ALL_CODECS, | |||
| ATTRIBUTE_CODEC_MASK, KafkaProtocol, | |||
| ) | |||
|
|
|||
| API_KEYS = { | |||
There was a problem hiding this comment.
What is the use case for this mapping? I could only think of logging...
There was a problem hiding this comment.
TBH, I created it primarily just to document the values. But there is some potential to switch the values from strings to the versioned list of class structs we have and use it for decoding api messages. That's obviously not in this PR though.
|
LGTM
|
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Oct 6, 2017
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards #865 . For now there is no change to behavior. We might consider faking the min/max data for old broker versions. I haven't looked at the java client to see how they handle this map, but this seems like a fairly easy step to at least get some logic into the connection object.