KAFKA-3977: defer fetch response parsing and raise exceptions to user #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/test_fetcher.py
Outdated
|
|
||
|
|
||
| def test__unpack_message_set(): | ||
| pass |
|
@tvoinarovskyi does this PR conflict with your work? do you want me to wait until your changes are ready to land or are you ok rebasing + dealing with any conflicts this may cause? |
|
@dpkp no, rather I would like to merge this first. I did not find time to implement deferred parsing myself) |
| def has_more(self): | ||
| return self.messages and self.message_idx < len(self.messages) | ||
|
|
||
| class FetchResponseMetricAggregator(object): |
There was a problem hiding this comment.
Will this aggregator behave properly in case CompletedFetch is not parsed? Say we parse 2 of 3 partitions and the user uses seek() which will cause the CompletedFetch to be discarded.
|
@dpkp I will merge this now. If you feel like some changes are needed please address them as a separate PR. I would like to rebase my PR on top to make it ready for merge, I think it's ready for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1141