Move callback processing from BrokerConnection to KafkaClient #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR handles the success case, but network failures in BrokerConnection.send / .recv still handle future.failure() inline. I am going to think a bit about how best to handle this so that both callbacks and errbacks can be handled in isolation (avoiding locking issues w/ background thread) |
tvoinarovskyi
approved these changes
Oct 20, 2017
|
Lgtm |
|
Merging this to lessen the burden of reviewing #1266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor to how response callbacks are processed. It is designed to separate the callback chain processing from the network processing code. This will allow us to use a threading lock around client networking that can be released before processing callbacks to reduce the risk of deadlock. This approach is derived from KAFKA-3888 / KIP-62 (background heartbeat thread).