Use socket timeout when blocking on send/recv #1281

dpkp · 2017-10-25T04:53:34Z

…on send

tvoinarovskyi · 2017-10-25T14:13:52Z

kafka/conn.py

@@ -501,10 +501,10 @@ def _send_bytes_blocking(self, data):
                raise ConnectionError('Buffer overrun during socket send')
            return total_sent
        finally:
-            self._sock.setblocking(False)
+            self._sock.settimeout(0.0)


You can leave it as setblocking(False). It's the same as per documentation.

Yes, they are the same. But I decided to use settimeout here for symmetry with the original call.

Use socket timeout of request_timeout_ms to prevent blocking forever …

b865d10

…on send

tvoinarovskyi approved these changes Oct 25, 2017

View reviewed changes

dpkp changed the title ~~Use socket timeout to prevent blocking forever in send~~ Use socket timeout when blocking on send/recv Oct 25, 2017

dpkp merged commit 34dc9dd into master Oct 25, 2017

jeffwidman deleted the conn_send_timeout branch October 30, 2017 20:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use socket timeout when blocking on send/recv #1281

Use socket timeout when blocking on send/recv #1281

dpkp commented Oct 25, 2017

tvoinarovskyi Oct 25, 2017

dpkp Oct 25, 2017

Use socket timeout when blocking on send/recv #1281

Use socket timeout when blocking on send/recv #1281

Conversation

dpkp commented Oct 25, 2017

tvoinarovskyi Oct 25, 2017

Choose a reason for hiding this comment

dpkp Oct 25, 2017

Choose a reason for hiding this comment