Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conn.py performance improvements, make examples work, add another example #131

Closed
wants to merge 3 commits into from
Closed

conn.py performance improvements, make examples work, add another example #131

wants to merge 3 commits into from

Conversation

wizzat
Copy link
Collaborator

@wizzat wizzat commented Feb 25, 2014

The change consists of:

  • Adding load_example.py, which shows large message behavior.
  • Updating example.py to actually compile and run.
  • Adding ErrorString handling so that human readable error messages are easier to get to.
  • Refactoring conn.py to use a common init/reinit pattern.
  • Refactoring conn.py to use ''.join() instead of str += str (~5-10% performance increase on my limited testing)

@wizzat
Copy link
Collaborator Author

wizzat commented Feb 25, 2014

This pull request is against my master, which is silly. I'm closing this pull request and will reopen it against a feature branch.

@wizzat wizzat closed this Feb 25, 2014
wbarnha added a commit to ax-ale/kafka-python that referenced this pull request Mar 10, 2024
@wbarnha @micwoj92
Update license_file to license_files (dpkp#131)
e0ebe5d 
The former has been deprecated since setuptools 56

Co-authored-by: micwoj92 <45581170+micwoj92@users.noreply.github.com>
bradenneal1 pushed a commit to bradenneal1/kafka-python that referenced this pull request May 16, 2024
@wbarnha @micwoj92 @bradenneal1
Update license_file to license_files (dpkp#131)
2e284fb 
The former has been deprecated since setuptools 56

Co-authored-by: micwoj92 <45581170+micwoj92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wizzat