Refactor dns lookup in BrokerConnection #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
reviewed
Dec 6, 2017
kafka/conn.py
Outdated
| self._gai = dns_lookup(self._init_host, self._init_port, self._init_afi) | ||
| if not self._gai: | ||
| log.error('DNS lookup failed for {0}:{1} ({2})' | ||
| .format(self._init_host, self._init_port, self._init_afi)) |
There was a problem hiding this comment.
Should probably be:
log.error('DNS lookup failed for %s:%i (%s)', self._init_host, self._init_port, self._init_afi)
dpkp
changed the title
|
Definitely - I always only squash / rebase land.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1306 by refactoring dns lookup / getaddrinfo handling in BrokerConnection.
The reported failure appears to be caused when DNS lookup fails or returns no data. In this case we were caching the empty gai data and never performed another DNS lookup. This prevented the client from "discovering" the broker again when it came back online. We also were not properly handling the connection failure to support reconnect backoff timers.