Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After digging into #1331 a bit it I found a few issues:
(1) heartbeat thread is not stopped unless KafkaConsumer is closed explicitly (or python interpreter exits).
(2) most connection objects have a circular reference preventing garbage collection prior to interpreter shutdown
(3) the client object also has a circular reference preventing gc prior to shutdown
This PR should fix these issues by using weakrefs to break circular references and by shutting down local resources like the heartbeat thread during gc via
__del__
It appears that there are still circular references preventing gc of KafkaMetrics and possibly SubscriptionState. These do not prevent the consumer, coordinator, client, or connection objects from being cleaned up, so I'm going to leave further fixes for a later PR.