Use absolute imports everywhere #1362
Conversation
There was a problem hiding this comment.
@kevinkjt2000 Why should we do this?
Is there a functional reason other than aesthetics?
The downside of this is that it's harder to re-organize the folder tree down the road...
.gitignore
Outdated
| tests-env/ | ||
| .pytest_cache/ |
There was a problem hiding this comment.
These changes should probably be in a separate PR as they are unrelated to import changes
There was a problem hiding this comment.
I have removed that by amending my commit.
kevinkjt2000
force-pushed
the
abosolute-imports
branch
from
fa4acfb to
27db4e8
Compare
|
@jeffwidman Python has trouble with relative imports when libraries are being imported from a zip file that is not extracted. These changes fix an issue in a new product of the company I develop for. |
|
I'm fine with this if/when tests pass. |
|
The test failure seems strange to me https://travis-ci.org/dpkp/kafka-python/jobs/335863422 |
|
There's some flaky tests... I restarted the failing test job.
To clarify, you're saying that you are importing python code straight from a zip file without extracting it? I did not realize python let you do this... |
|
@jeffwidman Yes. https://docs.python.org/2/library/zipimport.html Inserting a .zip file into the sys path allows python to import files from it. Which, after the trouble I have seen here, I would not recommend doing. All .so files also cannot load from a .zip file. Fun stuff. |
|
have you looked at https://github.com/pantsbuild/pex ? |
|
@dpkp pex looks promising! I will recommend it to my co-workers that work on that codebase more often. |
No description provided.