Short-circuit BrokerConnection.close() if already disconnected #1424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #1411 . It is fairly common when handling a connection error for us to call
self.close(error)
inside BrokerConnection, return an error to the caller, and for the caller -- usually KafkaClient -- to call conn.close() again. Right now this causes connection errors to be double logged, which can seem strange. The PR simply checks whether the connection is already disconnected, and if so it does nothing. We assume that the only way to get a BrokerConnection object into the disconnected state is viaclose()