-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Tests, fix connection error timeout, other issues #158
Conversation
…art working on intermittent failures in test_encode_fetch_request and test_encode_produc_request
The travis CI build will need updated to not manually run the test suite, but instead to rely on tox to run it for you. |
Alternatively, you can manually list all of the files in the directory. |
|
The tests should be stable now, and the three intermittently failing tests should be stable now. The tests should also be significantly faster. Merging this branch in will likely require changing the travis environment. I'd like to move kafka-src to kafka-src-0.8.0 and introduce a new submodule for kafka-src-0.8.1. |
I can rename the pull request, but the overwhelming bulk of the pull request is about adding and fixing the test suite. As to when it will get merged: not up to me. Probably for the best because I would push ALL THE CHANGES! ;-) |
So, the Travis build works now that I've disabled automatic checks of Pypy and Python2.6. I'll investigate travis-ci + tox + multiple versions of Python. |
from functools import partial | ||
from itertools import count | ||
from kafka.common import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks unnecessary? would like to avoid import *
Can you check the Travis CI build failure? |
This is a great PR. I've only added a few minor comments. Would merge immediately if we can get a passing Travis CI build. |
I'll try to have a fix for this in the next day or so. I worked off and on at this while I was working today (KIXEYE is sponsoring the work after all), but I'll have more time to focus on it tonight on the train ride home. Most of the code review comments will be addressed in the next commit. |
…or of in memory logging. Address code review concerns
kafka/client.py contained duplicate copies of same refactor, merged. Move test/test_integration.py changes into test/test_producer_integration. Conflicts: kafka/client.py servers/0.8.0/kafka-src test/test_integration.py
Yay! |
Improve Tests, fix connection error timeout, other issues
This is the initial pull request for improving the test suite. There are a few high level things that happened: