Stop pinning pylint
#1611
Merged
Stop pinning pylint
#1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed pylint-dev/pylint#2571 for the one error that is cropping up, as I believe it's a false positive. We'll see what the pylint folks say and whether I should work around it or wait for them to fix upstream. |
|
Cool, thanks. Those errors were bugging me) |
jeffwidman
added a commit
that referenced
this pull request
Oct 26, 2018
Temporarily workaround pylint-dev/pylint#2571 so that we can stop pinning `pylint` (#1611)
|
The |
jeffwidman
force-pushed
the
stop-pinning-pylint
branch
from
7515814 to
cbf21d3
Compare
jeffwidman
added a commit
that referenced
this pull request
Oct 26, 2018
Temporarily workaround pylint-dev/pylint#2571 so that we can stop pinning `pylint` (#1611)
Temporarily workaround pylint-dev/pylint#2571 so that we can stop pinning `pylint`.
jeffwidman
force-pushed
the
stop-pinning-pylint
branch
from
cbf21d3 to
a5234d9
Compare
We have many deprecation warnings in the travis logs for things that are fixed in newer versions of `pylint` or `pylint`'s dependencies. Note that `pylint` >= 2.0 does not support python 2, so this will result in different versions of pylint running for python 2 vs python 3. Personally, I am just fine with this.
jeffwidman
force-pushed
the
stop-pinning-pylint
branch
from
a5234d9 to
80b34bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many deprecation warnings in the travis logs for things that are fixed in newer versions of
pylintorpylint's dependencies.So opening a PR to see if
masterpasses on whatever version travis pulls in. Note thatpylint>= 2.0 does not support python 2, so this will result in different versions of pylint running for python 2 vs python 3. Personally, I am just fine with this.This change is