1701 use last offset from fetch v4 if available #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-offset-from-fetch-v4-if-available Conflicts: kafka/version.py
|
@tvoinarovskyi thoughts on this? (lgtm) |
|
@dpkp we can merge to mitigate the problem. I wanted to make it same as Java's approuch, but I can do that for the release after. |
|
Sounds good to me -- thanks for the PR! |
|
Thanks all. Wasn't too familiar with the code so happy to have it refactored later -- just needed something to work for right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reproduce #1701 locally
This PR fixes the issue where sometimes a consumer is stuck reading past certain offsets from a compacted topic if the last few messages from a partition have been removed by compaction and the server supports fetch V4 or above.
This change is