Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use test.fixtures.version not test.conftest.version to avoid warnings #1731

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Mar 6, 2019

Fixes pytest warning:

RemovedInPytest4Warning: Fixture "version" called directly.

Fixtures are not meant to be called directly, are created automatically
when test functions request them as parameters.
See https://docs.pytest.org/en/latest/fixture.html for more information.

This change is Reviewable

@dpkp dpkp merged commit 37699be into master Mar 7, 2019
@dpkp dpkp deleted the fix_fixture_version_warning branch March 7, 2019 03:10
@jeffwidman
Copy link
Collaborator

jeffwidman commented Mar 8, 2019

Thank you for this--it was bugging me a lot when I was workign on #1193 but I couldn't figure out what was triggering it... this is stupid simple. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants