Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont do client wakeup when sending from sender thread #1761

Merged
merged 2 commits into from
Mar 24, 2019
Merged

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Mar 22, 2019

Fix for #1760. the wakeup socketpair is used to signal a different, polling thread that a new request is ready to send on the network. But when the same thread is sending and polling, there is no need for wakeup, and furthermore it is possible that the wakeup itself could block if a large number of sends were processed before polling for responses.


This change is Reviewable

@dpkp dpkp force-pushed the sender_dont_wakeup branch from 59ac410 to 545cdb1 Compare March 23, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant