Dont treat popped conn.close() as failure in state change callback #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Apr 1, 2019
| node_id (int, optional): the id of the node to close | ||
| """ | ||
| with self._lock: | ||
| if node_id is None: |
There was a problem hiding this comment.
while the code is relatively clear, it'd be nice if the docstring stated that node_id=None results in closing all broker connections. The docstring implies it, but doesn't say that explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to KafkaClient's state_change_callback to attempt to avoid re-fetching Metadata or increasing bootstrap failure count after an intentional disconnect / conn.close()
This change is