Use Kafka Binaries for Integration Tests (Issue #176) #193
Conversation
|
+1! Thanks - I was about to have to do this myself. Any reservations about merging? |
|
i think it's good to merge. only additional bit I have been thinking about is whether we should remove build_integration.sh and have python download and install the binary tarballs (I started down that path with a simple classmethod to TestFixture but it isn't complete yet). right now it uses |
- previous 0.8.1 src appears to have actually been 0.8.1.1 based on git submodule commit. So technically this adds back 0.8.1 to the test suite.
|
Historical note. I didn't do this originally for a few reasons:
That last one is probably only a big deal for people relying on it for deployment automation. It's probably OK if one out of every 10000 Travis builds fails due to ASF server issues. |
To override defaults, use `tox -- --your --nosetest --options --here` Update default nosetest settings to use verbose logging and show test ids add .coverage and .noseids to .gitignore Add example for running single unit test to README
|
Yeah, I totally agree. It'll be important to start testing against 0.8.2 Soon(tm), and that's something that they just don't publish incremental binaries for. However, building so many versions of Kafka can make the tests take forever. I'd be in favor of keeping a "trunk" version of the code, but published versions should definitely used the published binaries. |
|
Let's merge this and support testing with KAFKA_VERSION=trunk as a separate task (whose priority will increase as 0.8.2 release gets closer). |
|
the PR now supports testing against trunk builds via My local testing suggests there are a lot of failing tests so I did not enable in .travis.yml . |
Use Kafka Binaries for Integration Tests (Issue #176)
|
Sounds great. We can wait until 0.8.2 gets closer before worrying overly much about trunk builds. Thanks for this! :) |
Downloads are from https://archive.apache.org/dist/kafka/
Remove git submodules used for source checkouts
Use Travis Environment vars to parallelize tests across kafka versions