Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added crc32c optional lib to extras_require #2069

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Added crc32c optional lib to extras_require #2069

merged 1 commit into from
Sep 17, 2020

Conversation

mishas
Copy link

@mishas mishas commented Jun 23, 2020 •
edited by jeffwidman
Loading

Fix #2068.

This change is Reviewable

@mishas
Copy link
Author

mishas commented Jun 23, 2020

It seems like specifying an issue number in the title doesn't link the PR with the issue.
So - here it is: Issue #2068

@mishas
Copy link
Author

mishas commented Jul 17, 2020

Friendly ping?

jeffwidman
jeffwidman approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

My only question about is about the name... as we're essentially stuck with this long-term due to backwards compatibility concerns... but I couldn't come up with anything better.

@jeffwidman jeffwidman merged commit d09ff02 into dpkp:master Sep 17, 2020
@jeffwidman jeffwidman mentioned this pull request Sep 17, 2020
Closed
@jeffwidman jeffwidman changed the title Added crc32c extra requirement as per issue #2068 Added crc32c optional lib to extras_require Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use setuptools' "extras" feature for installing crc32c
3 participants
@mishas @jeffwidman @MishaSeltzer