-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Avoid multi-threaded auto-commit #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is done using shared memory objects provided by multiprocessing. Also fix a bug in auto-commit for - auto_commit_every_n
Conflicts: kafka/consumer.py kafka/util.py
@mahendra now that we have CI and the test are working again, can you rebase your changes and add some tests? |
sure. working on it. |
Conflicts: kafka/conn.py kafka/util.py
@mumrah I have re-arranged the code so that it will work in windows. The trick is in ensuring that the target parameter passed to multiprocessing.Process is a normal function. Do have a look and let me know. |
The problem we have with forking long-running python processes is that the child can potentially have the same memory footprint as the parent, which can be pretty large. |
Closing inactive PR. |
Note: This is done on top of #33
This is done using shared memory objects provided by multiprocessing.
Design
Also fix a bug in auto-commit for - auto_commit_every_n