Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made jsonl writes use gzip compression. #593

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Nov 12, 2024

Important

Adds gzip compression to JSONL file writes in JsonlExecutor.scala.

  • Behavior:
    • Adds gzip compression to JSONL file writes in JsonlExecutor.scala by setting option("compression", "gzip") in indexRecords.write.text(outputPath).
  • Misc:
    • No other changes or refactoring in the code.

This description was created by Ellipsis for 5a5ac38. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5a5ac38 in 14 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/main/scala/dpla/ingestion3/executors/JsonlExecutor.scala:67
  • Draft comment:
    Ensure that downstream processes can handle gzip-compressed files, as this change affects the output format.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change to use gzip compression is appropriate, but it's important to ensure that the downstream processes can handle gzip-compressed files.

Workflow ID: wflow_bCU816p6Gb7SCmBv


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mdellabitta mdellabitta merged commit 3b53fc9 into develop Nov 12, 2024
3 checks passed
@mdellabitta mdellabitta deleted the jsonl-output-compression branch November 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant