Fixed hardcoded minnesota endpoint.

[mdellabitta]

Important

Removed hardcoded endpoint in MdlHarvester and made it configurable via queryParams.

• Behavior:
  • Removed hardcoded endpoint URL in getFirstUrl() in MdlHarvester.scala.
  • Endpoint is now configurable via queryParams map using conf.harvest.endpoint.
• Configuration:
  • Added endpoint to queryParams map in MdlHarvester.scala.

^{This description was created by for 61e9873. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 61e9873 in 39 seconds

More details

• Looked at 28 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. src/main/scala/dpla/ingestion3/harvesters/api/MdlHarvester.scala:30

• Draft comment:
  Remove the trailing comma in the queryParams Map definition.

    "rows" -> conf.harvest.rows.getOrElse(defaultRows)

• Reason this comment was not posted:
  Confidence changes required: 50%
  The trailing comma in a Map definition is unnecessary and can lead to confusion.

2. src/main/scala/dpla/ingestion3/harvesters/api/MdlHarvester.scala:28

• Draft comment:
  Ensure that the endpoint parameter is validated and not set to an empty string, as this could lead to invalid URL construction.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_MOsLmshmbmimUQfo

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Consider adding validation to ensure the endpoint is a valid URL before using it in URIBuilder.