Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LazyList for Oai Files. #615

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Fixed LazyList for Oai Files. #615

merged 1 commit into from
Jan 2, 2025

Conversation

mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Jan 2, 2025

Important

Refactor localHarvest() in OaiFileHarvester.scala to use foreach instead of for loop for LazyList processing.

  • Refactor:
    • Change for loop to foreach in localHarvest() method of OaiFileHarvester.scala for processing LazyList elements.

This description was created by Ellipsis for f992060. It will automatically update as commits are pushed.

Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f992060 in 14 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/main/scala/dpla/ingestion3/harvesters/file/OaiFileHarvester.scala:154
  • Draft comment:
    Consider using a more descriptive variable name instead of result for clarity, such as fileResult. This applies to the foreach loop on line 154.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    The change from a for-loop to a foreach is appropriate for side-effect operations, but the code can be further improved for readability and consistency.

Workflow ID: wflow_lsvJMqgroDtDn6Xn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mdellabitta mdellabitta merged commit fe2cdac into main Jan 2, 2025
4 checks passed
@mdellabitta mdellabitta deleted the oai-file-harvester branch January 2, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant