Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support camera real-time detection and use model age and sex simultaneously #50

Closed
wants to merge 2 commits into from

Conversation

LilianYe
Copy link

No description provided.

@dpressel
Copy link
Owner

Will take a look when I get a chance!

@dpressel
Copy link
Owner

dpressel commented Nov 2, 2017

There are a few issues with this PR that would need resolution before I could merge it. The biggest issue is that I can see visually that there would be regressions on the face detection and single model runs. It also seems to add an unconditional dependency on dlib.

As a suggestion for future, formatting changes make reading the diff harder. Would recommend avoiding those -- I am happy to reformat, but would appreciate being able to keep that separate from code changes.

I am happy to use this as a reference and update the code in a way that I can verify will not break anything, or, if you prefer to keep working on this code so there are no regressions, I am open to that too!

Either way thanks for this!

@LilianYe
Copy link
Author

LilianYe commented Nov 7, 2017

Yeah, after reading your code carefully, I realize the dilb part is unnecessary. I am happy if you can verify the code.

@LilianYe LilianYe closed this Nov 7, 2017
@dpressel dpressel mentioned this pull request Mar 21, 2018
@priyanshugandhi
Copy link

@LilianYe can you let me know what command show be run on the console to run this script??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants