Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken CI due to deprecated github action artifact usage #88

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

mattlewis92
Copy link
Contributor

Fixes broken auto publishing due to github action v2 artifacts being used:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Also addresses another upcoming change by migrating away from the deprecated ::set-output syntax.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dae
Copy link

dae commented Dec 17, 2024

One other issue: I had to add --locked to 'cargo install cross', as otherwise it was pulling in a dep (home) that required Rust 1.81.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Going to merge this regardless of if it passes ci. Will fix in a separate pr and get this repo back up to date.

@dsherret dsherret merged commit 58c1266 into dprint:main Jan 5, 2025
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants