Skip to content

Commit

Permalink
Correctly exclude namespaces from apropos
Browse files Browse the repository at this point in the history
Confluence of bugs in orchard, cider-nrepl, and CIDER. CIDER was using
the wrong key to send excluded namespaces. cider-nrepl was not putting
this key in the right position for the orchard query. And orchard was
not correctly eliding cider.nrepl inlined deps.

- orchard: clojure-emacs/orchard#59
- nrepl: clojure-emacs/cider-nrepl#618
  • Loading branch information
dan sutton committed Jun 23, 2019
1 parent 1f67d57 commit 91536bb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cider-client.el
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ Optional arguments include SEARCH-NS, DOCS-P, PRIVATES-P, CASE-SENSITIVE-P."
,@(when docs-p '("docs?" "t"))
,@(when privates-p '("privates?" "t"))
,@(when case-sensitive-p '("case-sensitive?" "t"))
"filter-regexps" ,cider-filtered-namespaces-regexps))))
"exclude-regexps" ,cider-filtered-namespaces-regexps))))
(if (member "apropos-regexp-error" (nrepl-dict-get response "status"))
(user-error "Invalid regexp: %s" (nrepl-dict-get response "error-msg"))
(nrepl-dict-get response "apropos-matches"))))
Expand Down Expand Up @@ -586,7 +586,7 @@ returned."
(defun cider-sync-request:ns-list ()
"Get a list of the available namespaces."
(thread-first `("op" "ns-list"
"filter-regexps" ,cider-filtered-namespaces-regexps)
"exclude-regexps" ,cider-filtered-namespaces-regexps)
(cider-nrepl-send-sync-request)
(nrepl-dict-get "ns-list")))

Expand Down

0 comments on commit 91536bb

Please sign in to comment.