Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format code and remove unused code #81

Merged
merged 9 commits into from
Mar 2, 2024
Merged

Format code and remove unused code #81

merged 9 commits into from
Mar 2, 2024

Conversation

ysyecust
Copy link
Collaborator

@ysyecust ysyecust commented Mar 1, 2024

No description provided.

@zhengh96
Copy link
Contributor

zhengh96 commented Mar 1, 2024

I noticed that you removed all codes of rocm, did it mean that Uni-Dock v1.1 no longer support rocm arch? @ysyecust

@ysyecust
Copy link
Collaborator Author

ysyecust commented Mar 2, 2024

I noticed that you removed all codes of rocm, did it mean that Uni-Dock v1.1 no longer support rocm arch? @ysyecust

Before Uni-Dock v1.1, Uni-Dock supported rcom and cuda, but version 1.1 has a lot of performance optimizations for CUDA, so future updates will no longer support the rcom platform. If you need to use the rcom platform, you can use Uni-dock v1.0.

@ysyecust ysyecust requested a review from caic99 March 2, 2024 01:02
@ysyecust ysyecust merged commit 4193693 into main Mar 2, 2024
4 checks passed
@ysyecust ysyecust deleted the format_code branch March 2, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants