Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: mermaid helpers for installation and doing file based generation #1814

Merged
merged 13 commits into from
Aug 3, 2024

Conversation

dpvreony
Copy link
Owner

No description provided.

Copy link

github-actions bot commented Jul 14, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
nuget/TestableIO.System.IO.Abstractions 21.0.26 UnknownUnknown

Scanned Manifest Files

src/Whipstaff.Mermaid/Whipstaff.Mermaid.csproj
  • TestableIO.System.IO.Abstractions@21.0.26

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 67.90123% with 26 lines in your changes missing coverage. Please review.

Project coverage is 32.84%. Comparing base (db0db12) to head (738eeba).

Files Patch % Lines
...Whipstaff.Mermaid/Playwright/PlaywrightRenderer.cs 77.77% 5 Missing and 5 partials ⚠️
...taff.Playwright/PlaywrightBrowserTypeAndChannel.cs 43.75% 9 Missing ⚠️
...id/Playwright/GetDiagramResponseModelExtensions.cs 45.45% 6 Missing ⚠️
src/Whipstaff.Playwright/InstallationHelper.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
+ Coverage   32.44%   32.84%   +0.40%     
==========================================
  Files         236      239       +3     
  Lines        6328     6405      +77     
  Branches      424      431       +7     
==========================================
+ Hits         2053     2104      +51     
- Misses       4180     4201      +21     
- Partials       95      100       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Aug 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@dpvreony dpvreony merged commit b1712db into main Aug 3, 2024
9 of 10 checks passed
@dpvreony dpvreony deleted the feature/mermaid-helpers branch August 3, 2024 12:46
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant