Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Assembly Resolve Failure handling not exposed in wpf app host core #1881

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

dpvreony
Copy link
Owner

@dpvreony dpvreony commented Sep 4, 2024

No description provided.

Copy link

github-actions bot commented Sep 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
nuget/Nullable 1.3.1 UnknownUnknown

Scanned Manifest Files

src/Whipstaff.Runtime/Whipstaff.Runtime.csproj
  • Nullable@1.3.1

Copy link

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12.3% Coverage on New Code (required ≥ 80%)
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 13.20755% with 92 lines in your changes missing coverage. Please review.

Project coverage is 32.67%. Comparing base (14903f9) to head (9f541fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Whipstaff.Wpf/WpfApplication.cs 0.00% 33 Missing ⚠️
...x/Runtime/AppDomains/AssemblyResolverExtensions.cs 5.55% 17 Missing ⚠️
src/Whipstaff.Runtime/Maths/MathHelpers.cs 0.00% 15 Missing ⚠️
...ntime/HostOverride/HttpRequestMessageExtensions.cs 0.00% 8 Missing ⚠️
...staff.Runtime/HostOverride/InMemoryHostOverride.cs 0.00% 6 Missing ⚠️
...f.Runtime/Cryptography/X509/X509StoreExtensions.cs 0.00% 2 Missing ⚠️
...c/Whipstaff.Runtime/Extensions/StreamExtensions.cs 0.00% 2 Missing ⚠️
src/Whipstaff.Runtime/Extensions/TypeExtensions.cs 50.00% 2 Missing ⚠️
...staff.Runtime/Http/HttpRequestMessageExtensions.cs 50.00% 2 Missing ⚠️
...pstaff.Runtime/JobSequencing/JobSequenceByRange.cs 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
- Coverage   32.73%   32.67%   -0.07%     
==========================================
  Files         239      240       +1     
  Lines        6434     6452      +18     
  Branches      432      426       -6     
==========================================
+ Hits         2106     2108       +2     
- Misses       4228     4246      +18     
+ Partials      100       98       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpvreony dpvreony merged commit 127e6a7 into main Sep 4, 2024
7 of 10 checks passed
@dpvreony dpvreony deleted the fix/assemblyresolvefailures branch September 4, 2024 21:00
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant