-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for gpt-4o, gpt-4o-mini, text-embedding-3-small and text-embedding-3-large #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the new gpt-4o-mini model, since for each model is also handled the "versioned" name, I've added it.
Excited for this to merged! |
Co-authored-by: Luigi Pederzani <luigipederzani@gmail.com>
Co-authored-by: Luigi Pederzani <luigipederzani@gmail.com>
Co-authored-by: Luigi Pederzani <luigipederzani@gmail.com>
Co-authored-by: Luigi Pederzani <luigipederzani@gmail.com>
What is the ETA for this PR to be merged? |
+1 for merging this soon |
hey @dqbd , can this be reviewed, merged and released please? We are quite eager to try out the new gpt4o mini mostly because of the cost efficiency and we are dependant on this library to safely calculate the tokens utilized in case of streams for chat completions. |
FYI for anyone eager to just try it out ASAP - as you can see in the implementation of this PR, the underlying token counter seems to be the same as with |
@rynti that's exactly why merging this PR is no brainer. I think everybody is already doing something like |
This method may work currently, but it is not guaranteed. Just like the notorious if condition for determining Windows 9x: |
@dqbd could you please take a look and cut a new release if the PR is good? |
bump, can we get this in here? we're going to have to start forking to move this along, but would love to stay on the main release branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since package author has been unresponsive, I think we should include gpt-4o-2024-08-06
as well so that we can just release all at once
Co-authored-by: huytool157 <97813378+huytool157@users.noreply.github.com>
Co-authored-by: huytool157 <97813378+huytool157@users.noreply.github.com>
Co-authored-by: huytool157 <97813378+huytool157@users.noreply.github.com>
Co-authored-by: huytool157 <97813378+huytool157@users.noreply.github.com>
Hello! Sorry about the long delay! Will take a look as soon as possible! |
This pull request adds support for the new
gpt-4o-mini
model and closes the issue #111, #114 and #115.