Review suggestions #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
So that no conversion is needed Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
psi_suggestions
branch
from
425b027 to
6c1e12d
Compare
dqminh
reviewed
Oct 11, 2022
| type ( | ||
| PSIData = cgroups.PSIData | ||
| PSIStats = cgroups.PSIStats | ||
| ) |
There was a problem hiding this comment.
my impression was that we tried to make types separate from cgroups as much as possible, hence the disconnection and duplication here.
It's reasonable to say that we do not care about the separation (i.e. the types package is not really useful), in that case i would prefer to do the refactoring separately.
| } | ||
|
|
||
| type CpuStats struct { | ||
| CpuUsage CpuUsage `json:"cpu_usage,omitempty"` | ||
| ThrottlingData ThrottlingData `json:"throttling_data,omitempty"` | ||
| PSI PSIStats `json:"psi,omitempty"` | ||
| PSI *PSIStats `json:"psi,omitempty"` |
There was a problem hiding this comment.
it's preferable to be consistent with the rest, and do the refactoring later.
| @@ -82,7 +78,7 @@ type CpuUsage struct { | |||
| type Cpu struct { | |||
| Usage CpuUsage `json:"usage,omitempty"` | |||
| Throttling Throttling `json:"throttling,omitempty"` | |||
| PSI PSIStats `json:"psi,omitempty"` | |||
| PSI *PSIStats `json:"psi,omitempty"` | |||
There was a problem hiding this comment.
it's preferable to be consistent with the rest, and do the refactoring later.
| @@ -113,7 +109,7 @@ type Memory struct { | |||
| Kernel MemoryEntry `json:"kernel,omitempty"` | |||
| KernelTCP MemoryEntry `json:"kernelTCP,omitempty"` | |||
| Raw map[string]uint64 `json:"raw,omitempty"` | |||
| PSI PSIStats `json:"psi,omitempty"` | |||
| PSI *PSIStats `json:"psi,omitempty"` | |||
There was a problem hiding this comment.
it's preferable to be consistent with the rest, and do the refactoring later.
| } | ||
| } | ||
| if err := sc.Err(); err != nil { | ||
| err = sc.Err() | ||
| if err != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review suggestions for opencontainers#3358