fix: some of cities has wrong state codes #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mowaiskalam Thanks for your efforts. Much Appreciated. Can you please make those updates in Thanks again! |
|
@dr5hn Thanks for the review |
|
@mowaiskalam can you please remove the cities.csv and cities.sql from this PR and keep only world.sql? |
mowaiskalam
force-pushed
the
fix/cities_csv
branch
from
fd9a2ba to
6e7c5f6
Compare
|
@dr5hn Removed cities.csv and cities.sql from the PR |
dr5hn
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, firstly thank you for this database, this help a lot when working with country, state and cities in our applications
I was trying to create migration in our system using the csv files and find out that the
cities.csvfile has some wrong information of state code, verified that records from live demo find out that it has wrong state codeJust fixed those states codes