Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incongruent state_code and country_code for cities in Sevastopol #633

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

scottgigante
Copy link
Contributor

Closes #615

Copy link
Owner

@dr5hn dr5hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottgigante Thanks for working on this.

Just a heads up, you'll also need to update the state entry.

From:

(1912,'Sevastopol',182,'RU','20','UA-40',NULL,44.61665000,33.52536710,'2019-10-05 23:18:44','2022-08-31 15:52:51',1,'Q7525')

To:

(1912,'Sevastopol',230,'UA','20','UA-40',NULL,44.61665000,33.52536710,'2019-10-05 23:18:44','2022-08-31 15:52:51',1,'Q7525')

@scottgigante scottgigante requested a review from dr5hn July 28, 2023 22:30
@dr5hn
Copy link
Owner

dr5hn commented Aug 6, 2023

@scottgigante Sorry to bother you again. country_id field in states table should also be changed to 230.

@scottgigante
Copy link
Contributor Author

Done, thanks!

@dr5hn dr5hn merged commit 107f027 into dr5hn:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crimea (state_name: Sevastopol) is part of Ukraine
2 participants