Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: regions database table #657

Merged
merged 5 commits into from
Sep 2, 2023
Merged

Conversation

Freelenzer
Copy link
Contributor

@Freelenzer Freelenzer commented Aug 7, 2023

This add first implementation of region/continents

i will add a PR for Subregions later.

What else needs to be done here?

What can we add to regions? Timezones?

@Freelenzer Freelenzer force-pushed the feature/regions branch 3 times, most recently from 33685e6 to 69b6823 Compare August 11, 2023 17:31
@Freelenzer Freelenzer marked this pull request as ready for review August 11, 2023 17:40
@dr5hn
Copy link
Owner

dr5hn commented Aug 14, 2023

@Freelenzer Thank you for your hard work on this! I really appreciate it.

Can we please keep the region and subregion columns as is so they stay backwards compatible?

Also, can you please migrate the updates of the regions, subregions table and countries table within world.sql?

The JSON, CSV, XML & YAML formats will get autogenerated once this PR is merged. You don't have to worry about them.

@dr5hn dr5hn linked an issue Aug 14, 2023 that may be closed by this pull request
@dr5hn
Copy link
Owner

dr5hn commented Aug 15, 2023

@Freelenzer Can you please migrate the updates of the regions, subregions table and countries table within world.sql?

@Freelenzer
Copy link
Contributor Author

Freelenzer commented Aug 15, 2023

Yes Im on it 👍
Was just interrupted this morning 🌅

@Freelenzer
Copy link
Contributor Author

@dr5hn changes are commited now :)

@dr5hn
Copy link
Owner

dr5hn commented Aug 16, 2023

@Freelenzer Thanks for that! Can you please remove the countries.sql file updates? That file will be automatically generated.

@dr5hn
Copy link
Owner

dr5hn commented Aug 16, 2023

@Freelenzer Also, if you can integrate subregions table, that would be great.

@Freelenzer
Copy link
Contributor Author

@dr5hn Ok done.

I will do another PR for the subregions. First finish this :)

This is the draft:

#668

@dr5hn dr5hn merged commit 83d39f2 into dr5hn:master Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regions/Continents and Subregions
2 participants