Remove the compiler flag from ocaml-compiler
#21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of the flag in both ocaml-base-compiler and ocaml-compiler
causes opam's invariant computation to produce a poor invariant:
e.g. opam switch create 5.3.0~beta2 produced an invariant of
"ocaml-base-compiler" {= "5.3.0~beta2"} | "ocaml-compiler" {= "5.3.0~beta2"}
instead of the desired
"ocaml-base-compiler" {= "5.3.0~beta2"}
|
I'd recommend we pull this commit in just before the release candidate (which would want the same thing), just to stop churn? |
|
I think it is a good idea |
|
seems ok 👍 |
|
This PR can now be closed as ocaml#27145 was merged |
|
Ideed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by @kit-ty-kate. At present, if you run
opam init -c 4.14.2(oropam switch create 4.14.2) you get a switch invariant choosing between either ocaml-system.4.14.2 or ocaml-base-compiler.4.14.2With the new ocaml-compiler package layout, you'd now also get ocaml-compiler.4.14.2 - but this version allows optional reconfiguration options (flambda, etc.) which is a user surprise we should avoid.
The fix is simple and is to remove the
compilerflag from the package. This makes explicitly using ocaml-compiler in opam 2.0 slightly more awkward, but that hasn't been being suggested anyway.