updated types #164
Merged
updated types #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let me know when this can be merged |
|
This can be merged. I haven't heard back from anyone in the but it's at least an improvement. |
davehorton
approved these changes
Nov 10, 2023
danvirsen
added a commit
to danvirsen/drachtio-srf
that referenced
this pull request
Nov 13, 2023
* updated types * updated type definitions for localSdpA and localSdpB * added missing type definition for AOR
|
Did this get published? I see the correct (hopefully) Types in GitHub, but when I install, I am getting the older versions. You can see it here: https://npm.runkit.com/drachtio-srf/lib/@types/index.d.ts?t=1709934254176 Confirmed using: 4.5.31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently updated drachtio-srf and noticed that TypeScript types were added some time ago.
Unfortunately this broke my entire application since the types doesn't seem to match the actual API that closely.
This PR holds my attempt att merging my own local type definitions that I used up until this point with the ones in the project. I would appreciate if someone else could test this as well. My application works fine like this, but there might be types that are left undefined or wrongly defined.
#160